Skip to content

Angular Materials 18 - Remove redundancy#7127

Merged
cdavalos7 merged 8 commits into
tensorflow:masterfrom
cdavalos7:feature/upgrade17-18
Jun 17, 2026
Merged

Angular Materials 18 - Remove redundancy#7127
cdavalos7 merged 8 commits into
tensorflow:masterfrom
cdavalos7:feature/upgrade17-18

Conversation

@cdavalos7

Copy link
Copy Markdown
Contributor

Motivation for features / changes

  • Match the internal/upstream source. File bodies become identical to the internal version.
  • Follow the Angular Material 18 recommendation a single @use '@angular/material' as mat; with mat.m2-* calls is the canonical way to keep an M2-based theme.
  • Remove dead redundancy, three aliases pointing at one module is noise that makes the theme harder to read.

Technical description of changes

  • Replaced @use '@angular/material' as matm2; and @use '@angular/material' as matm2var; with one @use '@angular/material' as mat; per file.
  • Updated all symbol uses to match: matm2.* → mat.* and matm2var.* → mat.*. The m2- prefix on each symbol stays the same.
    Because all three old names already pointed to the same module, the compiled CSS does not change at all — this is only a namespace/readability cleanup, with no change in behavior or look.

@cdavalos7 cdavalos7 requested a review from arcra June 16, 2026 21:58
# Conflicts:
#	tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common/_lib.scss
#	tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/execution_data_component.scss
#	tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/graph_op_component.scss
#	tensorboard/webapp/feature_flag/views/feature_flag_dialog_component.scss
#	tensorboard/webapp/metrics/views/card_renderer/image_card_component.scss
#	tensorboard/webapp/metrics/views/card_renderer/scalar_card_component.scss
#	tensorboard/webapp/metrics/views/card_renderer/vis_linked_time_selection_warning_component.scss
#	tensorboard/webapp/metrics/views/main_view/filter_input_component.scss
#	tensorboard/webapp/metrics/views/main_view/main_view_component.scss
#	tensorboard/webapp/metrics/views/main_view/pinned_view_component.scss
#	tensorboard/webapp/metrics/views/metrics_container.scss
#	tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/scalar_column_editor_component.scss
#	tensorboard/webapp/metrics/views/right_pane/settings_view_component.scss
#	tensorboard/webapp/notification_center/_views/notification_center_component.scss
#	tensorboard/webapp/runs/views/runs_table/runs_data_table.scss
#	tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.scss
#	tensorboard/webapp/theme/_tb_palette.scss
#	tensorboard/webapp/theme/_tb_theme.template.scss
#	tensorboard/webapp/theme/_variable.scss
#	tensorboard/webapp/widgets/card_fob/card_fob_component.scss
#	tensorboard/webapp/widgets/content_wrapping_input/content_wrapping_input_component.scss
#	tensorboard/webapp/widgets/data_table/column_selector_component.scss
#	tensorboard/webapp/widgets/data_table/context_menu_component.scss
#	tensorboard/webapp/widgets/data_table/data_table_component.scss
#	tensorboard/webapp/widgets/data_table/filter_dialog_component.scss
#	tensorboard/webapp/widgets/data_table/header_cell_component.scss
#	tensorboard/webapp/widgets/dropdown/dropdown_component.scss
#	tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_axis_view.scss
Comment thread tensorboard/webapp/theme/_tb_theme.template.scss
@cdavalos7 cdavalos7 merged commit 651fc4f into tensorflow:master Jun 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants